Messages in this thread | | | Date | Mon, 11 Sep 2006 16:23:44 -0400 | From | Dave Jones <> | Subject | Re: [PATCH] fix warning: no return statement in function returning non-void in kernel/audit.c |
| |
On Mon, Sep 11, 2006 at 09:22:15PM +0200, Jesper Juhl wrote: > > > kauditd_thread() is being used in a call to kthread_run(). kthread_run() expects > > > a function returning 'int' which is also how kauditd_thread() is declared. Unfortunately > > > kauditd_thread() neglects to return a value which results in this complaint from gcc : > > > > > > kernel/audit.c:372: warning: no return statement in function returning non-void > > > > > > Easily fixed by just adding a 'return 0;' to kauditd_thread(). > > > > Which will never be reached. > > True, and gcc even seems to optimize it out, since the size of audit.o > doesn't change with the patch applied... So, it does no harm and it > silences the warning - so why not?
Ah well, works for me :)
> I guess one could add a small /* never reached */ comment...
Could do for completeness, though it should seem fairly obvious.
> > Does marking the function NORET_TYPE > > also silence the warning? > Nope :(
Bah!
Dave
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |