Messages in this thread | | | Date | Wed, 30 Aug 2006 12:13:39 -0400 | From | Daniel Drake <> | Subject | Re: [PATCH] VIA IRQ quirk fixup only in XT_PIC mode Take 2 |
| |
Sergio Monteiro Basto wrote: >> It does look like this patch was under discussion of being reverted >> before. See http://lkml.org/lkml/2005/9/26/183 > > To be honest, I prefer put again this : > > +#ifdef CONFIG_X86_IO_APIC > + if (nr_ioapics && !skip_ioapic_setup) > + return; > +#endif > +#ifdef CONFIG_ACPI > + if (acpi_irq_model != ACPI_IRQ_MODEL_PIC) > + return; > +#endif
Isn't this exactly the same as what was being suggested?
> about Linus suggestion : > - new_irq = dev->irq & 0xf; > + new_irq = dev->irq; > + if (!new_irq || new_irq >= 15) > + return; > > no, we have problem with VIA SATA controllers which have irq lower than > 15
Any chance you can provide a link to this example so that we can document the decision in the commit message?
Thanks, Daniel
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |