Messages in this thread Patch in this message | | | Date | Mon, 14 Aug 2006 19:48:17 +0200 (CEST) | From | Stefan Richter <> | Subject | [PATCH 2.6.18-rc4-mm1 4/8] ieee1394: sbp2: recheck node generation in sbp2_update |
| |
While sbp2_update() is doing its duties after a bus reset, another reset could happen. Don't accept new requests until the next undisturbed sbp2_update() or until sbp2_remove().
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> --- Index: linux/drivers/ieee1394/sbp2.c =================================================================== --- linux.orig/drivers/ieee1394/sbp2.c 2006-08-14 00:22:32.000000000 +0200 +++ linux/drivers/ieee1394/sbp2.c 2006-08-14 00:27:15.000000000 +0200 @@ -812,11 +812,12 @@ static int sbp2_update(struct unit_direc */ sbp2scsi_complete_all_commands(scsi_id, DID_BUS_BUSY); - /* Make sure we unblock requests (since this is likely after a bus - * reset). */ - atomic_set(&scsi_id->unfinished_reset, 0); - scsi_unblock_requests(scsi_id->scsi_host); - + /* Accept new commands unless there was another bus reset in the + * meantime. */ + if (hpsb_node_entry_valid(scsi_id->ne)) { + atomic_set(&scsi_id->unfinished_reset, 0); + scsi_unblock_requests(scsi_id->scsi_host); + } return 0; }
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |