[lkml]   [2006]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC PATCH 15/33] move segment checks to subarch
Arjan van de Ven wrote:
> On Tue, 2006-07-18 at 00:00 -0700, Chris Wright wrote:
>> plain text document attachment (i386-segments)
>> We allow for the fact that the guest kernel may not run in ring 0.
>> This requires some abstraction in a few places when setting %cs or
>> checking privilege level (user vs kernel).
>> - regs.xcs = __KERNEL_CS;
>> + regs.xcs = get_kernel_cs();
> Hi,
> wouldn't this patch be simpler if __KERNEL_CS just became the macro that
> currently is get_kernel_cs() for the XEN case? then code like this
> doesn't need changing at all...

The tradeoff is that then you can't use __KERNEL_CS is assembler code,
and it is used in entry.S to detect NMI / debug trap workarounds - which
don't actually need to be paravirtualized, as it is easier to hide the
nasty cases which cause those side effects.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2006-07-18 13:33    [W:0.232 / U:2.984 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site