lkml.org 
[lkml]   [2006]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 16/33] Add support for Xen to entry.S.
Arjan van de Ven wrote:
> On Tue, 2006-07-18 at 00:00 -0700, Chris Wright wrote:
>
>> +#ifndef CONFIG_XEN
>> movl %cr0, %eax
>> testl $0x4, %eax # EM (math emulation bit)
>> - jne device_not_available_emulate
>> - preempt_stop
>> - call math_state_restore
>> - jmp ret_from_exception
>> -device_not_available_emulate:
>> + je device_available_emulate
>> pushl $0 # temporary storage for ORIG_EIP
>> CFI_ADJUST_CFA_OFFSET 4
>> call math_emulate
>> addl $4, %esp
>> CFI_ADJUST_CFA_OFFSET -4
>> + jmp ret_from_exception
>> +device_available_emulate:
>> +#endif
>>
>
>
> Hi,
>
> can you explain what this chunk is for? It appears to be for the non-xen
> case due to the ifndef, yet it seems to visibly change the code for
> that... that deserves an explanation for sure ...
>

This inverts the logic of the test so that the lines:

preempt_stop
call math_state_restore
jmp ret_from_exception

can be hoisted out of the ifdef and shared in the Xen and non-Xen cases.

J

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-07-19 00:57    [W:0.400 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site