Messages in this thread | | | Date | Sat, 03 Jun 2006 15:26:05 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] klibc |
| |
maximilian attems wrote: > On Thu, 01 June 2006, H. Peter Anvin wrote: >> Brian F. G. Bidulock wrote: >>> On Thu, 01 Jun 2006, Bob Picco wrote: >>>> >>>> -#if !defined(__x86_64__) && !defined(__ia64__) && !defined(__sparc_v9__) >>>> +#if !defined(__x86_64__) && !defined(__ia64__) && !defined(__sparc_v9__) && \ >>>> + !defined(__powerpc64__) >>> Why not just !defined(__LP64__) ? >> _BITSIZE == 64 is really the right formula... if I remember correctly, there were some >> 64-bit platforms (Alpha?) which didn't conform, though. I will look at this later today. >> >> -hpa > > indeed aboves line contains an mistake by an earlier patch of mine. > > -#if !defined(__x86_64__) && !defined(__ia64__) && !defined(__sparc_v9__) > +#if !defined(__x86_64__) && !defined(__ia64__) && !defined(__arch64__) > > is atm needed to get statfs right on sparc. >
__arch64__ is ugly; it doesn't say it's a sparc thing. I have added -D__sparc_v9__ to the sparc64 MCONFIG file, so I think that's fine.
Perhaps the right thing to do is to make this an archconfig.h configurable.
-hpa - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |