Messages in this thread Patch in this message | | | Subject | [Patch] SKB leak in drivers/isdn/i4l/isdn_x25iface.c | From | Eric Sesterhenn <> | Date | Wed, 28 Jun 2006 22:06:07 +0200 |
| |
hi,
coverity spotted this leak (id #613), when we are not configured, we return without freeing the allocated skb.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6.17-git11/drivers/isdn/i4l/isdn_x25iface.c.orig 2006-06-28 22:02:38.000000000 +0200 +++ linux-2.6.17-git11/drivers/isdn/i4l/isdn_x25iface.c 2006-06-28 22:03:02.000000000 +0200 @@ -208,7 +208,7 @@ static int isdn_x25iface_receive(struct */ static int isdn_x25iface_connect_ind(struct concap_proto *cprot) { - struct sk_buff * skb = dev_alloc_skb(1); + struct sk_buff * skb; enum wan_states *state_p = &( ( (ix25_pdata_t*) (cprot->proto_data) ) -> state); IX25DEBUG( "isdn_x25iface_connect_ind %s \n" @@ -220,6 +220,8 @@ static int isdn_x25iface_connect_ind(str return -1; } *state_p = WAN_CONNECTED; + + skb = dev_alloc_skb(1); if( skb ){ *( skb_put(skb, 1) ) = 0x01; skb->protocol = x25_type_trans(skb, cprot->net_dev);
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |