lkml.org 
[lkml]   [2006]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] IPMI: use schedule in kthread
On Mon, 26 Jun 2006 09:08:19 -0500
MAILER-DAEMON@osdl.org wrote:

> The kthread used to speed up polling for IPMI was using udelay
> when the lower-level state machine told it to do a short delay.
> This just used CPU and didn't help scheduling, thus causing bad
> problems with other tasks. Call schedule() instead.
>
> Signed-off-by: Corey Minyard <minyard@acm.org>
>
> Index: linux-2.6.17/drivers/char/ipmi/ipmi_si_intf.c
> ===================================================================
> --- linux-2.6.17.orig/drivers/char/ipmi/ipmi_si_intf.c
> +++ linux-2.6.17/drivers/char/ipmi/ipmi_si_intf.c
> @@ -809,7 +809,7 @@ static int ipmi_thread(void *data)
> /* do nothing */
> }
> else if (smi_result == SI_SM_CALL_WITH_DELAY)
> - udelay(1);
> + schedule();
> else
> schedule_timeout_interruptible(1);
> }

calling schedule() isn't a lot of use either.

If CONFIG_PREEMPT it's of no benefit and will just chew CPU.

If !CONFIG_PREEMPT && !need_resched() then it's a no-op and will chew CPU.

If !CONFIG_PREEMPT && need_resched() then yes, it'll schedule away. This
is pretty much the only time that a simple schedule() is useful.



What are we actually trying to do in here?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-06-26 21:05    [W:0.341 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site