lkml.org 
[lkml]   [2006]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Xen-devel] [RFC PATCH 34/35] Add the Xen virtual network device driver.
    On Tue, May 09, 2006 at 09:55:33PM +1000, Herbert Xu wrote:
    > Hi Chris:
    >
    > Chris Wright <chrisw@sous-sol.org> wrote:
    > >
    > > +/** Send a packet on a net device to encourage switches to learn the
    > > + * MAC. We send a fake ARP request.
    > > + *
    > > + * @param dev device
    > > + * @return 0 on success, error code otherwise
    > > + */
    > > +static int send_fake_arp(struct net_device *dev)
    >
    > I think we talked about this before. I don't see why Xen is so special
    > that it needs its own gratuitous arp routine embedded in the driver.
    > If this is needed at all (presumably for migration) then it should be
    > performed by the management scripts which can send grat ARP packets just
    > as easily.

    There's at least two reasons why having it in the driver is preferable:
    - synchronizing sending the fake ARP request with when the device is
    operational -- you really want to make this well synchronized to keep
    unreachability as short as possible, especially when doing live
    migration
    - anybody but the guest might not know (all) the MAC addresses for which
    to send a fake ARP request

    christian

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-05-09 14:46    [W:0.022 / U:119.124 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site