lkml.org 
[lkml]   [2006]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH 34/35] Add the Xen virtual network device driver.
    * Stephen Hemminger (shemminger@osdl.org) wrote:
    > The stuff in /proc could easily just be added attributes to the class_device kobject
    > of the net device (and then show up in sysfs).

    Agreed, it's on the todo list to drop proc support there. Thought that
    was marked in the patch.

    > > +#define GRANT_INVALID_REF 0
    > > +
    > > +#define NET_TX_RING_SIZE __RING_SIZE((struct netif_tx_sring *)0, PAGE_SIZE)
    > > +#define NET_RX_RING_SIZE __RING_SIZE((struct netif_rx_sring *)0, PAGE_SIZE)
    > > +
    > > +static inline void init_skb_shinfo(struct sk_buff *skb)
    > > +{
    > > + atomic_set(&(skb_shinfo(skb)->dataref), 1);
    > > + skb_shinfo(skb)->nr_frags = 0;
    > > + skb_shinfo(skb)->frag_list = NULL;
    > > +}
    >
    > Could you use existing sk_buff_head instead of inventing your
    > own skb queue?

    Hmm, there is some standard skb_queue_tail happening. I don't have a
    clear idea what you mean.

    > > + u8 mac[ETH_ALEN];
    >
    > Isn't mac address already stored in dev->dev_addr and/or dev->perm_addr?

    Yes, I don't see the reason to keep in twice. It's basically a temp
    buffer, but it certainly appears we can eliminate it.

    thanks,
    -chris
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-05-10 01:38    [W:0.024 / U:0.008 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site