lkml.org 
[lkml]   [2006]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -rt] revert bh_lru_lock() to preempt_disable()

* Daniel Walker <dwalker@mvista.com> wrote:

> > i agree that this is a problem, but the fix is incorrect. What would be
> > the right approach is to convert the PER_CPU bh_lrus to PER_CPU_LOCKED,
> > and to use the appropriate primitives to use them. That automatically
> > makes this code rt-safe. (it isnt right now)
>
> Hmm, in UP it should be safe to access per cpu data under either a
> preempt_disable or local_irq_disable . I'm not sure how RT changes
> that .. Is there some other part of the code that isn't rt-safe, which
> I've overlooked ?

hm, you are right - that code can be in a preempt-off section. I've
applied your patch.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-05-03 22:58    [W:0.051 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site