Messages in this thread | | | Date | Wed, 3 May 2006 22:47:47 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH -rt] revert bh_lru_lock() to preempt_disable() |
| |
* Daniel Walker <dwalker@mvista.com> wrote:
> The bh_lru_lock() was set to disable interrupt to protect from > IPI's, which are only on SMP . So I don't think it's needed in UP > PREEMPT_RT configs.
i agree that this is a problem, but the fix is incorrect. What would be the right approach is to convert the PER_CPU bh_lrus to PER_CPU_LOCKED, and to use the appropriate primitives to use them. That automatically makes this code rt-safe. (it isnt right now)
Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |