Messages in this thread | | | From | Segher Boessenkool <> | Subject | Re: [PATCH 10/16] ehca: event queue | Date | Fri, 28 Apr 2006 00:55:10 +0200 |
| |
>> + if (ret != H_SUCCESS) { > > Common convention is to return 0 on success and -ESOMETHING on eror. > You might want to follow that and remove H_SUCCESS from the complete > code.
This return code doesn't come from anywhere within the kernel, though. If we change this, we should get rid of _every_ #define bladibla 0 Do we want that? (I do ;-) )
>> + if (!(vpage = ipz_qpageit_get_inc(&eq->ipz_queue))) { > > I personally despise assignments in conditionals. Not sure if this is > documented in CodingStyle, but IME most kernel hackers tend to dislike > it as well.
In this case it's obvious; put it on a separate line.
Segher
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |