Messages in this thread | | | Date | Thu, 27 Apr 2006 13:48:28 +0200 | From | Jörn Engel <> | Subject | Re: [PATCH 10/16] ehca: event queue |
| |
On Thu, 27 April 2006 12:49:17 +0200, Heiko J Schick wrote: > > + ret = hipz_h_alloc_resource_eq(shca->ipz_hca_handle,
Indentation?
> + &eq->pf, > + type, > + length, > + &eq->ipz_eq_handle, > + &eq->length, > + &nr_pages, &eq->ist); > + > + if (ret != H_SUCCESS) {
Common convention is to return 0 on success and -ESOMETHING on eror. You might want to follow that and remove H_SUCCESS from the complete code.
> + if (!(vpage = ipz_qpageit_get_inc(&eq->ipz_queue))) {
I personally despise assignments in conditionals. Not sure if this is documented in CodingStyle, but IME most kernel hackers tend to dislike it as well.
Jörn
-- Don't patch bad code, rewrite it. -- Kernigham and Pike, according to Rusty - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |