Messages in this thread | | | Subject | Re: [PATCH] drivers/scsi/sd.c: fix uninitialized variable in handling medium errors | From | James Bottomley <> | Date | Wed, 26 Apr 2006 18:22:03 -0500 |
| |
On Wed, 2006-04-26 at 16:14 -0700, Andrew Morton wrote: > It'd be nice to have something simple-and-obvious for the > simple-and-obvious -stable maintainers. That's if we think -stable needs > this fixed.
Well .. the original will do for that.
> > + int sector_size_div = > > + 512 / SCpnt->device->sector_size; > > + error_sector /= sector_size_div; > > You sure about this bit?
Yes. If the <hardware sector size> is < 512 bytes then to convert the listed error sector to the standard 512 byte sector size block index, we have to divide (512/<hardware sector size>).
James
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |