Messages in this thread | | | Date | Wed, 26 Apr 2006 19:28:59 -0400 | From | Mark Lord <> | Subject | Re: [PATCH] drivers/scsi/sd.c: fix uninitialized variable in handling medium errors |
| |
James Bottomley wrote: > On Wed, 2006-04-26 at 19:04 -0400, Mark Lord wrote: >> Yes, but the difficulty there is that all of the convoluted logic >> seems to still be wanted to set a correct "block_sectors" value, >> needed as a parameter on the final call: >> >> scsi_io_completion(SCpnt, good_bytes, block_sectors << 9); > > Erm, but that's only used for volume overflow (or other single sector > errors), which this isn't ... Actually, as far as I can tell, the whole > block_sectors calculation can be killed as well.
I wonder if it can be done away with as a parameter for scsi_io_completion() ? If not, then we'll need some nice big comments in that function to warn against relying on a valid value for that parameter in specific cases.
Cheers - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |