lkml.org 
[lkml]   [2006]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/5] Swapless V2: Revise main migration logic

On Thu, 13 Apr 2006 16:54:32 -0700 (PDT)
Christoph Lameter <clameter@sgi.com> wrote:

>
> + inc_mm_counter(mm, anon_rss);
> + get_page(new);
> + set_pte_at(mm, addr, ptep, pte_mkold(mk_pte(new, vma->vm_page_prot)));
> + page_add_anon_rmap(new, vma, addr);

Just a note:

This will cause unecessary copy-on-write later.
(current remove_from_swap() can cause copy-on-write....)
But maybe copy-on-write is just minor case for migrating specified vmas.

For hotremove (I stops it now..), we should fix this later (if we can do).
If new SWP_TYPE_MIGRATION swp entry can contain write protect bit,
hotremove can avoid copy-on-write but things will be more complicated.

-Kame

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-04-14 03:20    [W:0.094 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site