Messages in this thread | | | Date | Fri, 14 Apr 2006 09:48:25 -0700 (PDT) | From | Christoph Lameter <> | Subject | Re: [PATCH 5/5] Swapless V2: Revise main migration logic |
| |
On Fri, 14 Apr 2006, KAMEZAWA Hiroyuki wrote:
> I just compiled this patch (because I cannot use NUMA now.)
I can give this a spin later today. > > BTW, why MAX_SWAPFILES_SHIFT==5 now ? required by some arch ?
No idea.
> +/* write protected page under migration*/ > +#define SWP_TYPE_MIGRATION_WP (MAX_SWAPFILES - 1) > +/* write enabled migration type */ > +#define SWP_TYPE_MIGRATION_WE (MAX_SWAPFILES)
Could we call this SWP_TYPE_MIGRATION_READ / WRITE?
> + pte = pte_mkold(mk_pte(new, vma->vm_page_prot)); > + if (is_migration_entry_we(entry)) { is_write_migration_entry?
> + pte = pte_mkwrite(pte); > + }
No {} needed.
> - entry = make_migration_entry(page); > + if (pte_write(pteval)) > + entry = make_migration_entry(page, 1); > + else > + entry = make_migration_entry(page, 0); > }
entry = make_migration_entry(page, pte_write(pteval))
? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |