Messages in this thread Patch in this message | | | Date | Thu, 13 Apr 2006 16:16:31 +0200 | From | Jörn Engel <> | Subject | [PATCH] Improve parameter parsing for block2mtd |
| |
Expand the parameter parsing for block2mtd. It now accepts: Ki, Mi, Gi - the official prefixes for binary multiples, see http://physics.nist.gov/cuu/Units/binary.html, ki - mistake on my side and analog to "k" for decimal multiples, KiB, MiB, GiB - for people that prefer to add a "B" for byte, kiB - combination of the above.
There were complaints about not accepting "k" for 1024. This has long been common practice, but is known to lead to confusion. Hence the new SI units and hence block2mtd only accepts units that cannot be confused with decimal units. Diverging from common practice doesn't always please people, even if the change is for the better.
Signed-off-by: Jörn Engel <joern@wohnheim.fh-wedel.de> ---
drivers/mtd/devices/block2mtd.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-)
--- block2mtd/drivers/mtd/devices/block2mtd.c~block2mtd_interface 2006-04-04 10:55:45.000000000 +0200 +++ block2mtd/drivers/mtd/devices/block2mtd.c 2006-04-12 13:58:53.000000000 +0200 @@ -4,7 +4,7 @@ * block2mtd.c - create an mtd from a block device * * Copyright (C) 2001,2002 Simon Evans <spse@secret.org.uk> - * Copyright (C) 2004,2005 Jörn Engel <joern@wh.fh-wedel.de> + * Copyright (C) 2004-2006 Jörn Engel <joern@wh.fh-wedel.de> * * Licence: GPL */ @@ -351,6 +351,12 @@ devinit_err: } +/* This function works similar to reguler strtoul. In addition, it + * allows some suffixes for a more human-readable number format: + * ki, Ki, kiB, KiB - multiply result with 1024 + * Mi, MiB - multiply result with 1024^2 + * Gi, GiB - multiply result with 1024^3 + */ static int ustrtoul(const char *cp, char **endp, unsigned int base) { unsigned long result = simple_strtoul(cp, endp, base); @@ -359,11 +365,15 @@ static int ustrtoul(const char *cp, char result *= 1024; case 'M': result *= 1024; + case 'K': case 'k': result *= 1024; /* By dwmw2 editorial decree, "ki", "Mi" or "Gi" are to be used. */ if ((*endp)[1] == 'i') - (*endp) += 2; + if ((*endp)[2] == 'B') + (*endp) += 3; + else + (*endp) += 2; } return result; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |