Messages in this thread | | | Date | Fri, 31 Mar 2006 06:55:57 -0700 | From | Matthew Wilcox <> | Subject | Re: [KJ][Patch] fix kbuild warning in sisfb.o |
| |
On Fri, Mar 31, 2006 at 03:29:29PM +0200, Adrian Bunk wrote: > > This is caused by the 'pci_driver struct' in sis_main.c having a pointer > > to a 'pci_device_id struct' in 'sis_main.h' that is marked as > > __devinitdata. > > > > The patch below just removes the __devinitdata annotation from the > > 'pci_device_id struct', which seems like the best solution here. > > ACK, this is a bug that should be fixed.
If it is, then Documentation/pci.txt needs to be updated:
The struct pci_driver shouldn't be marked with any of these tags. The ID table array should be marked __devinitdata.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |