lkml.org 
[lkml]   [2006]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] Fix potential NULL pointer deref in gen_init_cpio
Date
Fix potential NULL pointer deref in gen_init_cpio.c spotted by 
coverity checker.
This fixes coverity bug #86

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---

usr/gen_init_cpio.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletion(-)

--- linux-2.6.16-rc6-mm2-orig/usr/gen_init_cpio.c 2006-01-03 04:21:10.000000000 +0100
+++ linux-2.6.16-rc6-mm2/usr/gen_init_cpio.c 2006-03-18 22:17:18.000000000 +0100
@@ -471,6 +471,7 @@ int main (int argc, char *argv[])
"ERROR: incorrect format, could not locate file type line %d: '%s'\n",
line_nr, line);
ec = -1;
+ break;
}

if ('\n' == *type) {
@@ -506,7 +507,8 @@ int main (int argc, char *argv[])
line_nr, line);
}
}
- cpio_trailer();
+ if (ec == 0)
+ cpio_trailer();

exit(ec);
}


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-03-18 22:23    [W:0.057 / U:1.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site