Messages in this thread | | | Subject | RE: acpi thermal driver leaks in failure path | Date | Fri, 10 Mar 2006 22:32:29 -0500 | From | "Brown, Len" <> |
| |
applied.
thanks, -Len
>-----Original Message----- >From: Dave Jones [mailto:davej@redhat.com] >Sent: Wednesday, March 08, 2006 10:12 PM >To: Linux Kernel >Cc: Brown, Len >Subject: acpi thermal driver leaks in failure path > >Leaking memory in failure path. > >Coverity: #601 >Signed-off-by: Dave Jones <davej@redhat.com> > >--- linux-2.6/drivers/acpi/thermal.c~ 2006-03-08 >22:09:51.000000000 -0500 >+++ linux-2.6/drivers/acpi/thermal.c 2006-03-08 >22:11:05.000000000 -0500 >@@ -942,8 +942,10 @@ acpi_thermal_write_trip_points(struct fi > memset(limit_string, 0, ACPI_THERMAL_MAX_LIMIT_STR_LEN); > > active = kmalloc(ACPI_THERMAL_MAX_ACTIVE * sizeof(int), >GFP_KERNEL); >- if (!active) >+ if (!active) { >+ kfree(limit_string); > return_VALUE(-ENOMEM); >+ } > > if (!tz || (count > ACPI_THERMAL_MAX_LIMIT_STR_LEN - 1)) { > ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "Invalid argument\n")); >-- >http://www.codemonkey.org.uk > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |