lkml.org 
[lkml]   [2006]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/13] ATA ACPI: debugging infrastructure
Jeff Garzik <jgarzik@pobox.com> wrote:
>
> Fine-grained
> message selection allows one to turn on only the messages needed, and
> only for the controller desired.

Except

- There's (presently) no way of making all the messages go away for a
non-debug build.

- The code is structured as

if (ata_msg_foo(p))
printk("something");

So if we later do

#define ata_msg_foo(p) 0

We'll still get copies of "something" in the kernel image (may be fixed
in later gcc, dunno).

- The new debug stuff isn't documented. One has funble around in the
source to work out how to even turn it on. Can it be altered at runtime?
Dunno - the changelogs are risible. What effect do the various flags
have?

Having spent (and re-spent) time grovelling through the ALSA source
working out how to enable their debug stuff during a maintainer snooze
I'd prefer we didn't have to do that with libata as well.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-02-28 13:21    [W:0.069 / U:25.636 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site