lkml.org 
[lkml]   [2006]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: suspend2 review [was Re: Which is simpler? (Was Re: [Suspend2-devel] Re: [ 00/10] [Suspend2] Modules support.)]
On Ne 19-02-06 19:35:36, Dmitry Torokhov wrote:
> On Sunday 19 February 2006 18:42, Pavel Machek wrote:
> > --- linux-2.6.15-1/drivers/input/serio/serio.c  2006-01-03 15:08:26.000000000 +1000
> > +++ build-2.6.15.1/drivers/input/serio/serio.c  2006-01-23 21:38:28.000000000 +1000
> > @@ -314,6 +314,12 @@
> >  
> >                 serio_remove_duplicate_events(event);
> >                 serio_free_event(event);
> > +
> > +               if (unlikely(todo_list_active())) {
> > +                       up(&serio_sem);
> > +                       try_todo_list();
> > +                       down(&serio_sem);
> > +               }
> >         }
> >  
> >         up(&serio_sem);
> >
> > What is this?
> >
>
> I think it is a leftover from when serio and gameport cores were not
> "swsusp friendly" and were not releasing semaphore untill all pending
> messages have been processed. If you remember swsusp used to fail in
> this case. It can be safely dropped now.
>
> Overall as you noted alot of changes in Nigel's patch are useable outside
> of swsuspend2 so it's intrusiveness is not as big as you making it appear.

Yes, some of them are usaeable outside. But many of them were
attempted outside and vetoed for whatever reason :-(.
Pavel
--
Web maintainer for suspend.sf.net (www.sf.net/projects/suspend) wanted...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-02-20 01:46    [W:0.326 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site