Messages in this thread Patch in this message | | | Date | Wed, 1 Nov 2006 01:40:37 +0100 | From | Adrian Bunk <> | Subject | [2.6 patch] net/tipc/port.c: fix NULL dereference |
| |
The correct order is: NULL check before dereference
Spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6/net/tipc/port.c.old 2006-11-01 00:37:58.000000000 +0100 +++ linux-2.6/net/tipc/port.c 2006-11-01 00:38:27.000000000 +0100 @@ -1136,11 +1136,12 @@ int res = -EINVAL; p_ptr = tipc_port_lock(ref); + if (!p_ptr) + return -EINVAL; + dbg("tipc_publ %u, p_ptr = %x, conn = %x, scope = %x, " "lower = %u, upper = %u\n", ref, p_ptr, p_ptr->publ.connected, scope, seq->lower, seq->upper); - if (!p_ptr) - return -EINVAL; if (p_ptr->publ.connected) goto exit; if (seq->lower > seq->upper) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |