lkml.org 
[lkml]   [2006]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2.6.19-rc3] i386/io_apic: fix compiler warning in create_irq

* Andrew Morton <akpm@osdl.org> wrote:

> > this is an initialize-to-zero annotation for a false-positive gcc
> > warning. If it's not in Jeff tree yet then it should be there ...
>
> hm, I wouldn't call that "annotation".
>
> Now, the
>
> #define SHUT_GCC_UP(x) = x
>
> ...
> int foo SHUT_GCC_UP(foo);
> ...
>
> (or whatever it was) trick was "annotation". A good way of doing it
> too, IMO.

hm, i thought Jeff's tree was doing that ...

we definitely do not want to hide these places. They both make the code
less readable (why initialize it to some value if that value is never
used) and they hide the problem from the GCC folks too.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-31 12:19    [W:0.714 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site