lkml.org 
[lkml]   [2006]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2.6.19-rc3] i386/io_apic: fix compiler warning in create_irq
    On Tue, 31 Oct 2006 10:37:37 +0100
    Ingo Molnar <mingo@redhat.com> wrote:

    > On Mon, 2006-10-30 at 17:04 -0800, Andrew Morton wrote:
    > > > > irq = -ENOSPC;
    > > > > + vector = 0;
    > > >
    > > > NAK - the code is fine, and this is fixed in Jeff's gcc-warnings
    > > tree
    > > > via annotation.
    > >
    > > err, what gcc-warnings tree?
    > >
    > > git
    > > +ssh://master.kernel.org/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git#gccbug
    > > just does lots of initialise-to-zero thingies, doesn't have any
    > > special
    > > annotation and doesn't fix io_apic.c.
    >
    > this is an initialize-to-zero annotation for a false-positive gcc
    > warning. If it's not in Jeff tree yet then it should be there ...
    >

    hm, I wouldn't call that "annotation".


    Now, the

    #define SHUT_GCC_UP(x) = x

    ...
    int foo SHUT_GCC_UP(foo);
    ...

    (or whatever it was) trick was "annotation". A good way of doing it too, IMO.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-10-31 10:53    [W:0.021 / U:0.444 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site