Messages in this thread | | | Date | Mon, 30 Oct 2006 15:14:54 -0500 | From | Jeff Dike <> | Subject | Re: [PATCH 03/11] uml ubd driver: var renames |
| |
On Sun, Oct 29, 2006 at 08:20:29PM +0100, Paolo 'Blaisorblade' Giarrusso wrote: > From: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it> > > and then call any "struct ubd" ubd_dev instead of dev, which doesn't > make clear what we're treating (and no, it's not hungarian notation - > not any more than calling all vm_area_struct vma or all inodes > inode).
I can't say that I like this part of it. I don't see any alternate interpretation of a variable called 'dev', and renaming it to 'ubd_dev' seems redundant, given that we are in the ubd driver.
Plus, this change sent a couple of lines over the 80-character boundary.
Jeff
Work email - jdike at linux dot intel dot com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |