Messages in this thread | | | Date | Mon, 30 Oct 2006 15:26:57 -0500 | From | Jeff Dike <> | Subject | Re: [PATCH 07/11] uml ubd driver: reformat ubd_config |
| |
On Sun, Oct 29, 2006 at 08:20:41PM +0100, Paolo 'Blaisorblade' Giarrusso wrote: > From: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
> - return(1); > + ret = 1; > + goto out;
> +out: > + return ret;
I think the original form should stay, except for the CodingStyle fix. As Al once pointed out, 'goto out; ... out: return' is spelled 'return'. If you have no cleanup to do before returning, you might as well just return.
> + if (n == -1) { > + ret = 0; > + goto out; > } > - if(n == -1) return(0);
The comment should have noted the bug fix present here.
Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |