Messages in this thread Patch in this message | | | Date | Sun, 29 Oct 2006 03:53:13 +0900 | From | Akinobu Mita <> | Subject | [PATCH] acpi: fix single linked list manipulation |
| |
This patch fixes single linked list manipulation for sub_driver. If the remving entry is not on the head of the sub_driver list, it goes into infinate loop.
Though that infinate loop doesn't happen. Because the only user of acpi_pci_register_dirver() is acpiphp.
Cc: Len Brown <len.brown@intel.com> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
drivers/acpi/pci_root.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
Index: work-fault-inject/drivers/acpi/pci_root.c =================================================================== --- work-fault-inject.orig/drivers/acpi/pci_root.c +++ work-fault-inject/drivers/acpi/pci_root.c @@ -98,11 +98,12 @@ void acpi_pci_unregister_driver(struct a struct acpi_pci_driver **pptr = &sub_driver; while (*pptr) { - if (*pptr != driver) - continue; - *pptr = (*pptr)->next; - break; + if (*pptr == driver) + break; + pptr = &(*pptr)->next; } + BUG_ON(!*pptr); + *pptr = (*pptr)->next; if (!driver->remove) return; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |