lkml.org 
[lkml]   [2006]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.6.19-rc2-mm1
On Wed, 18 Oct 2006 23:44:03 +0200 (CEST)
Jiri Kosina <jikos@jikos.cz> wrote:

> [PATCH] VFS: fix i_mutex locking in page_symlink()
>
> The inode->i_mutex should be held every time when calling i_size_write(),
> and the function contains WARN_ON() for that condition.
> page_symlink(), however, does not lock i_mutex. It is perfectly OK, as the
> i_mutex for the directory is held at the time page_symlink() is running,
> so noone is able to change i_size during race condition. However,
> i_size_write() spits out the warning without this patch.
>

I suspect it isn't necessary because the symlink's inode hasn't been wired
up into the directory tree yet and no other thread can find it and do
things to it.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-19 00:33    [W:0.208 / U:2.544 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site