Messages in this thread Patch in this message | | | Date | Mon, 16 Oct 2006 09:28:39 -0600 | From | "Adam Jerome" <> | Subject | [PATCH] kallsyms: report consistent types for non-exported symbols |
| |
From: Adam B. Jerome <abj@novell.com>
This patch addresses incorrect symbol type information reported through /proc/kallsyms. A lowercase character should designate the symbol as local (or non-exported). An uppercase character should designate the symbol as global (or external). Without this patch, some non-exported symbols are incorrectly assigned an upper-case designation in /proc/kallsyms. This patch corrects this condition by converting non-exported symbols types to lower case when appropriate and eliminates the superfluous upcase_if_global function.
Please apply.
Signed-off-by: Adam B. Jerome <abj@novell.com>
---
I do not subscribe to the list. Please CC posted answers/comments to me <abj@novell.com>. Thanks; -adam
diff -urpN linux-2.6-git/kernel/kallsyms.c linux-2.6-cur/kernel/kallsyms.c --- linux-2.6-git/kernel/kallsyms.c 2006-10-16 08:53:33.000000000 -0600 +++ linux-2.6-cur/kernel/kallsyms.c 2006-10-16 09:09:36.000000000 -0600 @@ -20,6 +20,7 @@ #include <linux/proc_fs.h> #include <linux/sched.h> /* for cond_resched */ #include <linux/mm.h> +#include <linux/ctype.h> #include <asm/sections.h> @@ -301,13 +302,6 @@ struct kallsym_iter char name[KSYM_NAME_LEN+1]; }; -/* Only label it "global" if it is exported. */ -static void upcase_if_global(struct kallsym_iter *iter) -{ - if (is_exported(iter->name, iter->owner)) - iter->type += 'A' - 'a'; -} - static int get_ksymbol_mod(struct kallsym_iter *iter) { iter->owner = module_get_kallsym(iter->pos - kallsyms_num_syms, @@ -316,7 +310,10 @@ static int get_ksymbol_mod(struct kallsy if (iter->owner == NULL) return 0; - upcase_if_global(iter); + /* Label it "global" if it ix exported, "local" if not exported. */ + iter->type = is_exported(iter->name, iter->owner) + ? toupper(iter->type) : tolower(iter->type); + return 1; }
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |