Messages in this thread | | | Date | Tue, 10 Oct 2006 06:55:34 +0200 | From | Adrian Bunk <> | Subject | Re: [PATCH] Add Kconfig dependency !VT for VIOCONS |
| |
On Fri, Oct 06, 2006 at 02:34:37PM -0700, Randy Dunlap wrote: > On Fri, 6 Oct 2006 13:00:07 -0700 Judith Lebzelter wrote: > > > Actually, this gets rid of the CONFIG_VIOCONS from my .config, but > > then I get another warning when I build: > > > > Warning! Found recursive dependency: VT VIOCONS VT > > > > Can anyone suggest something? > > I think that your patch is mostly good/correct, but one more line > is needed on the VT side: a deletion. > > This works for me: > > From: Randy Dunlap <rdunlap@xenotime.net> > > Make allmodconfig .config build successfully by making VIOCONS > available only if VT=n. VT need not check VIOCONS. > > Signed-off-by: Randy Dunlap <rdunlap@xenotime.net> > --- > arch/powerpc/platforms/iseries/Kconfig | 2 +- > drivers/char/Kconfig | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) > > --- linux-2619-rc1g2.orig/arch/powerpc/platforms/iseries/Kconfig > +++ linux-2619-rc1g2/arch/powerpc/platforms/iseries/Kconfig > @@ -3,7 +3,7 @@ menu "iSeries device drivers" > depends on PPC_ISERIES > > config VIOCONS > - tristate "iSeries Virtual Console Support (Obsolete)" > + tristate "iSeries Virtual Console Support (Obsolete)" if !VT > help >... > config VT > bool "Virtual terminal" if EMBEDDED
With this dependency on EMBEDDED, you could as well simply remove VIOCONS...
> select INPUT > - default y if !VIOCONS
Removing the "default y" is wrong.
> ---help--- > If you say Y here, you will get support for terminal devices with > display and keyboard devices. These are called "virtual" because you >... > ~Randy
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |