lkml.org 
[lkml]   [2006]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: Potential fix for fdtable badness.
Date
On Tuesday 10 October 2006 19:31, Andrew Morton wrote:
> On Tue, 10 Oct 2006 19:08:18 -0700
>
> Vadim Lobanov <vlobanov@speakeasy.net> wrote:
> > Would you prefer me to resend a fixed patch #4, or a new fix (#5) on top
> > of what's in your tree?
>
> Incremental updates are preferred.
>
> > diff -Npru old/fs/file.c new/fs/file.c
> > --- old/fs/file.c 2006-10-10 18:58:21.000000000 -0700
> > +++ new/fs/file.c 2006-10-10 19:01:03.000000000 -0700
> > @@ -164,9 +164,8 @@ static struct fdtable * alloc_fdtable(un
> > * the fdarray into page-sized chunks: starting at a quarter of a page,
> > * and growing in powers of two from there on.
> > */
> > - nr++;
> > nr /= (PAGE_SIZE / 4 / sizeof(struct file *));
> > - nr = roundup_pow_of_two(nr);
> > + nr = roundup_pow_of_two(nr + 1);
> > nr *= (PAGE_SIZE / 4 / sizeof(struct file *));
> > if (nr > NR_OPEN)
> > nr = NR_OPEN;
>
> Like that.

I'll wrap the fixes up in incremental patches once the problem has been
eradicated.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-11 04:43    [W:0.077 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site