Messages in this thread Patch in this message | | | Subject | [PATCH 1/8] highmem: include asm/kmap_types.h in linux/highmem.h | Date | Sat, 14 Jan 2006 00:24:16 +0900 | From | Tejun Heo <> |
| |
On architectures where highmem isn't used, arguments to kmap/unmap are simply thrown away without being evaluated. This is fine until a wrapper function is written. Even though it got ignored in the end, the arguments are evaulated. As asm/highmem.h is not included by linux/highmem.h when CONFIG_HIGHMEM is off, none of KM_* constants get defined which results in error if those are evaluated.
This patch makes linux/highmem.h include asm/kmap_types.h regardless of CONFIG_HIGHMEM. To deal with the same problem, crypto subsystem used to include asm/kmap_types.h directly. This patch kills it.
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
crypto/internal.h | 1 - include/linux/highmem.h | 1 + 2 files changed, 1 insertions(+), 1 deletions(-)
4e0462fa09e87da901867f37b2c7311ef714c3e7 diff --git a/crypto/internal.h b/crypto/internal.h index 959e602..4188672 100644 --- a/crypto/internal.h +++ b/crypto/internal.h @@ -21,7 +21,6 @@ #include <linux/kernel.h> #include <linux/rwsem.h> #include <linux/slab.h> -#include <asm/kmap_types.h> extern struct list_head crypto_alg_list; extern struct rw_semaphore crypto_alg_sem; diff --git a/include/linux/highmem.h b/include/linux/highmem.h index 6bece92..c605f01 100644 --- a/include/linux/highmem.h +++ b/include/linux/highmem.h @@ -6,6 +6,7 @@ #include <linux/mm.h> #include <asm/cacheflush.h> +#include <asm/kmap_types.h> #ifdef CONFIG_HIGHMEM -- 1.0.6
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |