Messages in this thread | | | Date | Fri, 30 Sep 2005 10:23:39 +1000 | Subject | Re: [RFC][PATCH] identify in_dev_get rcu read-side critical sections | From | Herbert Xu <> |
| |
On Thu, Sep 29, 2005 at 04:59:56PM -0700, Suzanne Wood wrote: > Sorry to be thinking on-line, but if you mean this: > > if (in_dev = rcu_dereference(dev->ip_ptr)) > > I think that's fine.
Close. What I had in mind is
rcu_read_lock(); in_dev = dev->ip_ptr; if (in_dev) { in_dev = rcu_dereference(in_dev); atomic_inc(&in_dev->refcnt); } rcu_read_unlock(); return in_dev;
Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |