Messages in this thread | | | Date | Thu, 29 Sep 2005 16:59:56 -0700 (PDT) | From | Suzanne Wood <> | Subject | Re: [RFC][PATCH] identify in_dev_get rcu read-side critical sections |
| |
Sorry to be thinking on-line, but if you mean this:
if (in_dev = rcu_dereference(dev->ip_ptr))
I think that's fine.
> From suzannew Thu Sep 29 16:39:57 2005
> > From suzannew Thu Sep 29 16:30:28 2005
> > > From: Herbert Xu 30 Sep 2005 07:28
> > > BTW, could you please move the rcu_dereference in in_dev_get() > > > into the if clause? The barrier is not needed when ip_ptr is > > > NULL.
> > The trouble with that may be that there are three events, the > > dereference, the assignment, and the conditional test. The > > rcu_dereference() is meant to assure deferred destruction > > throughout.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |