lkml.org 
[lkml]   [2005]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2.6.13] libata: Marvell SATA support (PIO mode)
Christoph Hellwig wrote:
>>+#include <linux/kernel.h>
>>+#include <linux/module.h>
>>+#include <linux/pci.h>
>>+#include <linux/init.h>
>>+#include <linux/blkdev.h>
>>+#include <linux/delay.h>
>>+#include <linux/interrupt.h>
>>+#include <linux/sched.h>
>>+#include <linux/dma-mapping.h>
>>+#include "scsi.h"
>
>
> pleaese don't include "scsi.h" in new drivers. It will go away soon.
> Use the <scsi/*.h> headers and get rid of usage of obsolete constucts
> in your driver.


It stays until the rest of the libata drivers lose the include.

After ATAPI support is done, I can stop 2.4.x support, and this and
several other compat-isms will go away.

Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-09-01 21:52    [W:0.121 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site