lkml.org 
[lkml]   [2005]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] freevxfs: minor cleanups
Pekka Enberg <penberg@cs.helsinki.fi> wrote:
>
> This patch addresses the following minor issues:
>
> - Typo in printk
> - Redundant casts
> - Use C99 struct initializers instead of memset
> - Parenthesis around return value
> - Use inline instead of __inline__

That struct initialisation:

> + *infp = (struct vxfs_sb_info) {
> + .vsi_raw = rsbp,
> + .vsi_bp = bp,
> + .vsi_oltext = rsbp->vs_oltext[0],
> + .vsi_oltsize = rsbp->vs_oltsize,
> + };
>

Is a bit unconventional, but it doesn't alter the size of the .o file, so
whatever.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-06-29 01:55    [W:0.077 / U:0.724 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site