Messages in this thread | | | Date | Thu, 26 May 2005 15:53:30 -0700 | From | Greg KH <> | Subject | Re: [RFC] Changing pci_iounmap to take 'bar' argument |
| |
On Thu, May 26, 2005 at 02:07:34PM +1000, Benjamin Herrenschmidt wrote: > Hi ! > > On ppc and ppc64 platforms, pci_iounmap() currently does nothing, which > is bogus (leak of ioremap space for mmio). It needs to iounmap for MMIOs > and do nothign for IO space. > > The problem is that wether it's IO or MMIO cannot be easily deduced from > the virtual address. We _could_ change the whole thing on ppc32 to play > tricks with the top address bits, and we could compare the virtual > address with the known regions containing PHBs IO space, but that sounds > to me like working around a bad API in the first place. > > What about, instead, just adding the "int bar" argument to pci_iounmap() > like we pass to pci_iomap() so it can access the resource flags ? > > If it's ok with you, I'll send a patch doing it later today.
Fine with me.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |