Messages in this thread | | | Subject | Re: [RFC] Changing pci_iounmap to take 'bar' argument | From | Benjamin Herrenschmidt <> | Date | Thu, 26 May 2005 14:30:14 +1000 |
| |
On Thu, 2005-05-26 at 14:27 +1000, Benjamin Herrenschmidt wrote: > On Wed, 2005-05-25 at 21:25 -0700, Linus Torvalds wrote: > > > > On Thu, 26 May 2005, Benjamin Herrenschmidt wrote: > > > > > > If it's ok with you, I'll send a patch doing it later today. > > > > It's ok by me, certainly. There aren't that many users, and it sounds > > sane. I'll just prefer the patch going through Greg.. > > Ok, just wanted some feedback from you. Some people prefer that I whack > some "token" in the vitual address at map time, or that I compare the > vaddr at unmap time with all PCI busses IO ranges or that sort of ugly > thing, it sounds to me simpler to just pass along the bar number, but I > wanted your and Greg's ack first.
Oh, and MIPS seems to be broken here ... it's like ppc, it's ioremap'ing MMIO and just using an existing mapped stuff for IO, but unconditionally iounmap's on pci_iounmap()... unless there is some arch black magic in there, that seems broken. Ralph, should I fix it while I'm at it ?
Ben.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |