Messages in this thread | | | Date | Tue, 24 May 2005 20:58:55 +0400 | From | Ivan Kokshaysky <> | Subject | Re: [patch 2/2] x86_64: Collect host bridge resources |
| |
On Tue, May 24, 2005 at 08:45:36AM -0700, Rajesh Shah wrote: > The concern here isn't just increasing the size of pci_bus. The > resource pointers in pci_bus point to resource structures in the > corresponding pci_dev structure for p2p bridges. If we want to > maintain this scheme, we'd have to increase the number of resources > in the pci_dev structure too, which increases it for every single > pci device in the system.
No. The pci_bus resource pointers are just pointers to _some_ resources and generally aren't tied to particular pci device. For example, the root pci buses often don't even have corresponding bus->self structure, and bus resources are pointers to global io[mem,port]_resource. And definitely we must not touch resource layout in struct pci_dev - it's defined by pci specs.
> Probably ok for big server machines, but > would others (e.g. embedded folks) complain?
Increasing the size of pci_bus by 8 or 16 bytes shouldn't be a problem - I don't think embedded machines have a lot of pci buses. :-) Anyway, the default PCI_BUS_NUM_RESOURCES value can be overridden in arch specific headers.
Ivan. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |