Messages in this thread | | | Date | Tue, 24 May 2005 19:01:21 +0200 | From | Carsten Otte <> | Subject | Re: [RFC/PATCH 2/4] fs/mm: execute in place (3rd version) |
| |
Suparna Bhattacharya wrote:
> OK, though this leaves filemap.c alone which is good, I have to admit > >that this entire duplication of read/write routines really worries me. > >There has to be a third way. > > Just thinking loud here: When looking at patch v2, the read split is done in do_generic_mapping_read vs do_xip_mapping read. In the write path, the split is at generic_file_xip_write, generic_file_buffered_write and generic_file_direct_write. How about abstracting on that interface? Like make those become address space operations. This way, the filesystems could select the corresponding function. No need to distinguish between xip, direct_IO, and classic readpage/writepage in the generic code anymore. Would this go in the direction you're thinking Suparna? Is it worth a try to see how it comes out? Opinions anyone?
cheers, Carsten
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |