Messages in this thread | | | Date | Tue, 24 May 2005 15:00:29 +0530 | From | Suparna Bhattacharya <> | Subject | Re: [RFC/PATCH 2/4] fs/mm: execute in place (3rd version) |
| |
On Mon, May 23, 2005 at 07:30:20PM +0200, Carsten Otte wrote: > [RFC/PATCH 2/4] fs/mm: execute in place (3rd version) > > This part has changed alot again: > - generic_file* file operations do no longer have a xip/non-xip split > - filemap_xip.c implements a new set of fops that require get_xip_page > aop to work proper. all new fops are exported GPL-only (don't like to > see whatever code use those except GPL modules) > - __xip_unmap now uses page_check_address, which is no longer static > in rmap.c, and defined in linux/rmap.h > - mm/filemap.h is now much more clean, plainly having just Linus' > inline funcs moved here from filemap.c > - fix includes in filemap_xip to make it build cleanly on i386 > > diff -ruN linux-git/mm/filemap.h linux-git-xip/mm/filemap.h > --- linux-git/mm/filemap.h 1970-01-01 01:00:00.000000000 +0100 > +++ linux-git-xip/mm/filemap.h 2005-05-23 19:01:27.000000000 +0200 > @@ -0,0 +1,94 @@ > +/* > + * linux/mm/filemap.c > + *
I guess you meant "filemap.h" not "filemap.c" ? Shouldn't this be in include/linux instead ?
> + * Copyright (C) 1994-1999 Linus Torvalds > + */ > + > +#ifndef __FILEMAP_H > +#define __FILEMAP_H > + > +#include <linux/types.h> > +#include <linux/fs.h> > +#include <linux/mm.h> > +#include <linux/highmem.h> > +#include <linux/uio.h> > +#include <linux/config.h> > +#include <asm/uaccess.h> > +
> diff -ruN linux-git/mm/filemap_xip.c linux-git-xip/mm/filemap_xip.c > --- linux-git/mm/filemap_xip.c 1970-01-01 01:00:00.000000000 +0100 > +++ linux-git-xip/mm/filemap_xip.c 2005-05-23 19:01:42.000000000 +0200 > @@ -0,0 +1,581 @@ > +/* > + * linux/mm/filemap_xip.c > + * > + * Copyright (C) 2005 IBM Corporation > + * Author: Carsten Otte <cotte@de.ibm.com> > + * > + * derived from linux/mm/filemap.c - Copyright (C) Linus Torvalds > + * > + */ > + > + */ > +static ssize_t > +__xip_file_aio_read(struct kiocb *iocb, const struct iovec *iov, > + unsigned long nr_segs, loff_t *ppos) > +{
OK, though this leaves filemap.c alone which is good, I have to admit that this entire duplication of read/write routines really worries me.
There has to be a third way.
Regards Suparna
-- Suparna Bhattacharya (suparna@in.ibm.com) Linux Technology Center IBM Software Lab, India
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |