Messages in this thread | | | Date | Mon, 16 May 2005 19:26:33 -0700 | From | Matt Mackall <> | Subject | Re: serial console |
| |
On Tue, May 17, 2005 at 09:24:23AM +0800, Coywolf Qi Hunt wrote: > On 5/17/05, Matt Mackall <mpm@selenic.com> wrote: > > On Mon, May 16, 2005 at 04:37:12PM -0700, Andrew Morton wrote: > > > > > > It would be nicer if this was a static inline, so all the function call > > > code at the callsites is removed by the compiler. > > > > Better yet, a patch that's actually right. add_preferred_console is > > setting the console used by init and so on, so it's still relevant > > with CONFIG_PRINTK off. So I just move it out of the ifdef. Obviously > > more correct(tm). > > > > Move add_preferred_console out of CONFIG_PRINTK so serial console does > > the right thing. > > > What's the purpose of serial console if printk is disabled? I suggest > we put add_preferred_console and all its callers, console code etc > into CONFIG_PRINTK.
Serial console is currently two things: where to write kernel messages, and the terminal init is attached to.
-- Mathematics is the supreme nostalgia of our time. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |