lkml.org 
[lkml]   [2005]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: serial console
    On 5/17/05, Matt Mackall <mpm@selenic.com> wrote:
    > On Mon, May 16, 2005 at 04:37:12PM -0700, Andrew Morton wrote:
    > >
    > > It would be nicer if this was a static inline, so all the function call
    > > code at the callsites is removed by the compiler.
    >
    > Better yet, a patch that's actually right. add_preferred_console is
    > setting the console used by init and so on, so it's still relevant
    > with CONFIG_PRINTK off. So I just move it out of the ifdef. Obviously
    > more correct(tm).
    >
    > Move add_preferred_console out of CONFIG_PRINTK so serial console does
    > the right thing.


    What's the purpose of serial console if printk is disabled? I suggest
    we put add_preferred_console and all its callers, console code etc
    into CONFIG_PRINTK.

    --
    Coywolf Qi Hunt
    http://sosdg.org/~coywolf/
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-05-17 03:29    [W:0.024 / U:0.448 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site