Messages in this thread | | | Date | Wed, 11 May 2005 17:33:59 +0200 | From | Carsten Otte <> | Subject | Re: [RFC/PATCH 2/5] mm/fs: add execute in place support |
| |
Christoph Hellwig wrote:
> This is a lot of code for a very special case. > >Could you try to put all the xip code into a separate file, e.g. mm/xip.c >that's only built when CONFIG_XIP is set? It would probably require >duplicating a little more code if you want clean interfaces, e.g. probably >a separate set of generic operations. > > > Indeed that seems reasonable. There is no exact reason to have this built into a kernel on a platform that does not have a bdev for this. On the other hand, I believe the code should stay in filemap.c, because it fits there conceptually. And I personally dislike #ifdef in the middle of a file. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |