Messages in this thread Patch in this message | | | Subject | [patch 007/198] crypto: call zlib end functions on deflate exit path | From | akpm@osdl ... | Date | Tue, 12 Apr 2005 03:30:38 -0700 |
| |
From: Artem B. Bityuckiy <dedekind@infradead.org>
In the deflate_[compress|uncompress|pcompress] functions we call the zlib_[in|de]flateReset function at the beginning. This is OK. But when we unload the deflate module we don't call zlib_[in|de]flateEnd to free all the zlib internal data. It looks like a bug for me. Please, consider the attached patch.
Signed-off-by: Artem B. Bityuckiy <dedekind@infradead.org> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Cc: "David S. Miller" <davem@davemloft.net> Signed-off-by: Andrew Morton <akpm@osdl.org> ---
25-akpm/crypto/deflate.c | 2 ++ 1 files changed, 2 insertions(+)
diff -puN crypto/deflate.c~crypto-call-zlib-end-functions-on-deflate-exit-path crypto/deflate.c --- 25/crypto/deflate.c~crypto-call-zlib-end-functions-on-deflate-exit-path 2005-04-12 03:21:05.178349672 -0700 +++ 25-akpm/crypto/deflate.c 2005-04-12 03:21:05.181349216 -0700 @@ -93,11 +93,13 @@ out_free: static void deflate_comp_exit(struct deflate_ctx *ctx) { + zlib_deflateEnd(&ctx->comp_stream); vfree(ctx->comp_stream.workspace); } static void deflate_decomp_exit(struct deflate_ctx *ctx) { + zlib_inflateEnd(&ctx->decomp_stream); kfree(ctx->decomp_stream.workspace); } _ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |