lkml.org 
[lkml]   [2005]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [ANNOUNCE][PATCH 2.6.11 2/3] megaraid_sas: Announcing new mod ule for LSI Logic's SAS based MegaRAID controllers
Date
Bagalkote, Sreenivas <sreenib@lsil.com> wrote:

>>> . And since this is compile time
>>> system-wide property, I kept it as driver global.
>>
>>that step I don't understand... why is it a global *VARIABLE* if it's
>>compile time system-wide property...
>>
>
> I see your point! Are you saying I should use if(sizeof(dma_addr_t)==8)
> instead of the shortcut if(is_dma64)? Are you thinking of "const" modifier?
> Please advice.

If using a static const variable produces about the same code a macro does,
the variable is OK. Otherwise you'll have to use a #define in order to avoid
including dead code.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:11    [W:0.116 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site