Messages in this thread | | | From | Bodo Eggert <> | Subject | RE: [ANNOUNCE][PATCH 2.6.11 2/3] megaraid_sas: Announcing new mod ule for LSI Logic's SAS based MegaRAID controllers | Date | Wed, 09 Mar 2005 18:59:22 +0100 |
| |
Bagalkote, Sreenivas <sreenib@lsil.com> wrote:
>>> . And since this is compile time >>> system-wide property, I kept it as driver global. >> >>that step I don't understand... why is it a global *VARIABLE* if it's >>compile time system-wide property... >> > > I see your point! Are you saying I should use if(sizeof(dma_addr_t)==8) > instead of the shortcut if(is_dma64)? Are you thinking of "const" modifier? > Please advice.
If using a static const variable produces about the same code a macro does, the variable is OK. Otherwise you'll have to use a #define in order to avoid including dead code. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |