Messages in this thread | | | Date | Tue, 15 Mar 2005 11:02:53 -0800 (PST) | From | Christoph Lameter <> | Subject | Re: [PATCH 0/2] del_timer_sync: proof of concept |
| |
On Tue, 15 Mar 2005, Oleg Nesterov wrote:
> Christoph Lameter wrote: > > > > However, this also means that __run_timers will not free up the timer and > > it has to be explicitly freed with del_timer_??. > > I am not sure I understand you but no, del_timer{,_sync} is not needed. > > __run_timer deletes timer from base->tv? list and clears 'pending flag'. > > __del_timer_sync sets ->_base = NULL, but it is merely optimization. > It could set ->_base = base, but in that case next del_timer_sync() > call will need spin_lock(base->lock) again.
For some reason I thought that ->base == NULL would have special significance outside of the function you discussed. Looks fine to me now.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |